London | May-2025 | Ikenna Agulobi | Structuring and Testing Data sprint-3 #614

ike-agu · 2025-06-26T19:49:52Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.
This PR includes my completed exercises for Sprint 3 in the Structuring and Testing Data module.

###The exercises included in this PR:###

1- key-implement
2- mandatory-rewrite
3- mandatory-practice
4- stretch-investigate

Questions

Ask any questions you have for your reviewer.

Hello @cjyuan - I wasn't able to complete the test cases for Card validator in Stretch-investigate. Given that it's not among mandatory exercises, can I come back to it when I have more time as I'm a bit behind?

cjyuan · 2025-07-04T01:32:01Z

Your PR is created against CYF's coursework/sprint-3 and not against CYF's main. Can you change the current PR so that it is compared to CYF's main?

ike-agu · 2025-07-04T10:55:40Z

Hi @cjyuan , I've updated my PR to point to CodeYourFuture:main as requested. Please let me know if anything else needs to be changed. Thank you!

cjyuan · 2025-07-04T11:18:11Z

This branch was created from branch "coursework/sprint-2" instead of from main. As a result, it includes changes made in "Sprint-2" folder.

Can you rebase your coursework/sprint-3 branch onto main?

The following instructions assume you had created a branch named B2 (coursework/sprint-3) from a branch named B1 (coursework/sprint-2) instead of from main, and you wanted to rebase B2 from B1 onto main.

Important:

You need to execute the commands within your cloned repository.
You may want to backup your files before trying these commands

1. Open Your Cloned Repository in VSCode and Start a Terminal in VSCode.

VSCode will start the terminal in the top-level folder of the current project.

2. Switch to the branch you want to rebase (`B2`)

git switch B2

Note:

You can check which branch is the current branch via the command git branch (to list all branches with current branch highlighted)

3. Rebase `B2` from `B1` onto `main`

git rebase --onto main B1 B2

For more details about this command, ask an AI tool or see
https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase#:~:text=interactive%20rebase%20display-,Advanced%20rebase%20application,-The%20command%20line

4. Update (and Overwrite) your files in the remote branch B2 (on Github)

While you are in branch B2 and you have verified that it has been successfully rebased, execute the following command to update the remote branch (on GitHub):
git push --force origin

…t-angle-type

…e while loop

… message for password already been used

ike-agu · 2025-07-05T14:54:10Z

Hi @cjyuan , thank you for your feedback. I've now rebased the coursework/sprint-3 branch onto main as you requested, and I have removed the unintended changes from sprint-2 and I've also force-pushed the updated branch to GitHub.
Please let me know if there's anything else I need to adjust. Thanks!!

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

Sprint-3/3-mandatory-practice/implement/repeat.js

Sprint-3/3-mandatory-practice/implement/repeat.test.js

Sprint-3/4-stretch-investigate/card-validator.js

cjyuan · 2025-07-05T16:18:01Z

Sprint-3/4-stretch-investigate/password-validator.test.js

+const isValidPassword = require("./password-validator.js");
 test("password has at least 5 characters", () => {
    // Arrange
-    const password = "12345";
+    const password = "Abc1!";
    // Act
    const result = isValidPassword(password);
    // Assert
    expect(result).toEqual(true);
 }
-);
+);


The check only ensure the function can return true when the password is correct; it does not ensure the function can return false when a password does not meet the condition specified.

The same applies to the other tests in this script.

I've added test cases to check that my function returns false when password is too short, has no special character, has no number, no upper case and has no lower case as you've requested. Thanks!

…er or greater or equals to 360

…so implemeye

…pted.

…ominators

…1, 12, 13

…e and make it easier to maintain

…g too short, no special character, no number, no upper or lower case.

ike-agu · 2025-07-07T01:19:16Z

Hi @cjyuan , I've implemented all the changes you requested. Could you please take a look. Thank you 🙏

cjyuan

Changes look good. Well done.

cjyuan · 2025-07-07T01:54:21Z

Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js

    // add your completed function from key-implement here
-    if (numerator >= denominator) return false;
+    if(denominator === 0){
+      return "Denominator cannot be zero"


Return a string from a function that is expected to return a Boolean value can make consuming the return value inconvenient.

Consider the alternatives:

return false (to indicate anything divided by 0 is not a proper fraction)

throw an error

cjyuan · 2025-07-07T01:58:01Z

Sprint-3/4-stretch-investigate/password-validator.test.js

@@ -56,3 +56,34 @@ test("password must not be any previous password in the passwords array", ()=> {
  const result = isValidPassword(password);
  expect(result).toEqual(false);
 });
+
+test("fails when password is less than 5 characters", () => {
+  const password = "A1!";


Should also include a lowercase letter.

cjyuan · 2025-07-07T01:58:59Z

You forgot to change label to "Needs review". :P

ike-agu added the Needs Review Participant to add when requesting review label Jun 26, 2025

ike-agu mentioned this pull request Jun 26, 2025

02 Complete Sprint 3 coursework ike-agu/My-Coursework-Planner#60

Open

cjyuan added the 👀 Review Git Changes requested to do with Git label Jul 4, 2025

ike-agu changed the base branch from to-be-deleted-coursework/sprint-3 to main July 4, 2025 10:48

ike-agu added 23 commits July 5, 2025 11:54

Implemented condition to check if angle is less than 90

29f288e

added conditional statements and assertions to complete exercise 1-ge…

bb789a2

…t-angle-type

added test assertions to complete exercise 2-is-proper-fraction

de201cb

Impleneted function to get card value for exercise 3-get-card-value.js

dbe53d3

added completed getAngleType funtion from Key-implement exercise

9756c95

Added tests for get angle type exercise

e1f86d2

added my isProperFraction function from key-implement

2f478fd

I added tests is Proipoer Fraction exercise

f796929

added codes from getCardValue function

3fe535b

added tests for get card value exercise

5b28aa1

added completed getAngleType funtion from Key-implement exercise

a124d85

added tests for getOrdinalNumber from 1 - 11

65fb383

added tests cases for repeat.test exercise

a777952

Implemented credit card validator function

0071b2f

Added comments to answer questions regarding the function find and th…

1e9d34d

…e while loop

implemented passwordValidator function

8d57ee1

added test to check if password has uppercase or lowercase letter

2c3d18a

added test to check if password has atleast one number 0-9

4dc0a9e

added test to check if password has atleast one non-aphanumeric symbols

7cd8988

fixed test to check if password has already been used. Changed return…

1f98cca

… message for password already been used

Changed return message for password already been used to equals to false

60897ed

Implemented get get ordinal number function

9e62f36

fixed test cases for get ordinal numbers function

9de4207

ike-agu added 3 commits July 5, 2025 11:54

fixed test case password has atleast 5 characters

224044d

Implemented count Character function

1e0ea6c

Implemented repeat function

79fcbe9

ike-agu force-pushed the coursework/sprint-3 branch from 4ad048f to 79fcbe9 Compare July 5, 2025 11:08

Implemented functionality to check the cards are not all the same digit

826f604

edit the file in line 4

24e0cbe

cjyuan reviewed Jul 5, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed 👀 Review Git Changes requested to do with Git Needs Review Participant to add when requesting review labels Jul 5, 2025

ike-agu added 13 commits July 5, 2025 23:44

added checks for angle less than or equals to zero and the ones great…

bee5248

…er or greater or equals to 360

implemented isProper fraction to ensure denominator is not zero. I al…

8947ab5

…so implemeye

updated get-card-value.js to ensure only standard card ranks are acce…

155ed1e

…pted.

updated get-card-value.js to throw new Error(Invalid Card rank).

c619fd9

implemented is proper fraction to handle negative values and zero den…

03edb9b

…ominators

fixed function to handle zero denominators and negative numbers

30550bc

grouped test cases under the category append 'th' to numbers ending 1…

2b0b26f

…1, 12, 13

updated get-card-value.js to throw new Error(Invalid Card rank).

4180eb3

I group test cases for numbers ending in 1,2 and 3 to improve coverag…

32ab610

…e and make it easier to maintain

Implemented throw new error message

586fbd2

fixed the test case to throw error when count is negative

6cd07d3

I added test cases to to return false when the password is invalid e.…

ffd50fa

…g too short, no special character, no number, no upper or lower case.

I added = sign to check if sum is <= to 16

9eff376

cjyuan reviewed Jul 7, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jul 7, 2025

Uh oh!

London | May-2025 | Ikenna Agulobi | Structuring and Testing Data sprint-3 #614

Are you sure you want to change the base?

London | May-2025 | Ikenna Agulobi | Structuring and Testing Data sprint-3 #614

Conversation

ike-agu commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan commented Jul 4, 2025

Uh oh!

ike-agu commented Jul 4, 2025

Uh oh!

cjyuan commented Jul 4, 2025

1. Open Your Cloned Repository in VSCode and Start a Terminal in VSCode.

2. Switch to the branch you want to rebase (B2)

3. Rebase B2 from B1 onto main

4. Update (and Overwrite) your files in the remote branch B2 (on Github)

Uh oh!

ike-agu commented Jul 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Jul 5, 2025

Choose a reason for hiding this comment

Uh oh!

ike-agu Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

ike-agu commented Jul 7, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ike-agu commented Jun 26, 2025 •

edited

Loading

2. Switch to the branch you want to rebase (`B2`)

3. Rebase `B2` from `B1` onto `main`

cjyuan commented Jul 7, 2025 •

edited

Loading